Chinese Remainder Theorem | Diophantine Equation | Modular Division #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cclauss Your review, please. |
cclauss
requested changes
Oct 2, 2019
There was a problem hiding this comment.
Can we put these into data_structures/hashes?
The overlap in the three open PRs is making reviews difficult. Let's close or land some of them.
| # 2. Take n = ra*by + rb*ax | ||
|
|
||
| # import testmod for testing our function | ||
| from doctest import testmod |
There was a problem hiding this comment.
Let's move this line down just below line 68...
We do not need this import when we run your functions, only when we test them.
| return (n % m + m) % m | ||
|
|
||
|
|
||
| if __name__ == '__main__': |
| @@ -0,0 +1,70 @@ | |||
| # Chinese Remainder Theorem: | |||
|
|
|||
| # If GCD(a,b) = 1, then for any remainder ra modulo a and any remainder rb modulo b there exists integer n, | |||
There was a problem hiding this comment.
Please expand the acronym GCD and try to keep the lines to 88 characters or less.
|
|
||
| # This function find the inverses of a i.e., a^(-1) | ||
| def invert_modulo(a, n): | ||
| (b, x) = extended_euclid(a, n) |
|
|
||
| # Euclid's Algorithm | ||
|
|
||
| def gcd(a, b): |
| # Uses ExtendedEuclid to find the inverse of a | ||
|
|
||
| # Import testmod for testing our function | ||
| from doctest import testmod |
OddExtension5
changed the title
|
OK...
|
This was referenced Oct 3, 2019
Closed
…/hashing/number_theory
…/hashing/number_theory
|
Done.. |
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
…heAlgorithms#1248) * Update .gitignore to remove __pycache__/ * added chinese_remainder_theorem * Added Diophantine_equation algorithm * Update Diophantine eqn & chinese remainder theorem * Update Diophantine eqn & chinese remainder theorem * added efficient modular division algorithm * added GCD function * update chinese_remainder_theorem | dipohantine eqn | modular_division * update chinese_remainder_theorem | dipohantine eqn | modular_division * added a new directory named blockchain & a files from data_structures/hashing/number_theory * added a new directory named blockchain & a files from data_structures/hashing/number_theory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.